Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in configuration dialog options capitalisation #5201

Open
nvaccessAuto opened this issue Jul 8, 2015 · 3 comments
Open

Consistency in configuration dialog options capitalisation #5201

nvaccessAuto opened this issue Jul 8, 2015 · 3 comments
Labels

Comments

@nvaccessAuto
Copy link

Reported by leonarddr on 2015-07-08 09:54
Following #1980 en #2015, I did some other capitalisation checks. The following items don't stick to the first letter capitalisation rule:

Review Cursor:

  • Follow System Caret > Follow system caret

Browse mode:

  • Automatic Say All on page load > Automatic say all on page load? (This one is tricky, since Say All is a command name, we might want to leave this as it is. However, it is still inconcistent with focus mode, for example
@nvaccessAuto
Copy link
Author

Comment 1 by dkager on 2015-07-10 10:58
There are also some phrases that miss caps:

# git grep _(\"[settingsDialogs.py
settingsDialogs.py:             (log.INFO,_("info")),
settingsDialogs.py:             (log.DEBUGWARNING,_("debug warning")),
settingsDialogs.py:             (log.IO,_("input/output")),
settingsDialogs.py:             (log.DEBUG,_("debug"))
settingsDialogs.py:             self.textUnitComboBox=wx.Choice(self,wx.ID_ANY,name=_("text reporting unit"),choices=[textInfos.unitLabels[x](a-z]) for x in self.textUnits])
settingsDialogs.py:             ("off",_("off")),
settingsDialogs.py:             self.dictList.InsertColumn(3,_("case"),width=50)
settingsDialogs.py:             self.offOn = (_("off"),_("on"))
settingsDialogs.py:             self.tetherValues=[("focus",_("focus")),("review",_("review"))]

Some if not all of these should be capitalized.

@bhavyashah
Copy link

Sounds like a quick fix. Mind taking this up some time? @LeonarddeR @dkager @josephsl

@dkager
Copy link
Collaborator

dkager commented Aug 19, 2017

Very much one for @LeonarddeR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants