Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichEdit: Don't report hidden hyperlink instruction for friendly name links #5241

Open
nvaccessAuto opened this issue Jul 24, 2015 · 3 comments
Labels

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-07-24 00:00
STR:

  1. Open the attached test case in Wordpad.
  2. Ensure reporting of links and formatting changes after the cursor are enabled.
  3. Report the line of text in the file.

Notes:

  • As explained in this article, friendly name hyperlinks contain a hidden instruction prefix. Unfortunately, this does get included in returned text.
  • If we detect a link and the text has a ' HYPERLINK "' prefix (note the space at the start), we can strip this, since simple URL hyperlinks will never start with this string.
  • However, if we're detecting formatting changes after the cursor, the hidden prefix will be a separate range. We should only do this stripping on the first link range, since the second can contain arbitrary text. The end will be: text.find('"', 12) + 2
  • Unfortunately, simply stripping this will break braille cursor routing. We'll probably need to invent a way to indicate an arbitrary number of hidden characters and teach braille to handle this.
  • Braille cursor routing is also broken for embedded objects, since they just shove extra text into the output. We should probably use fields for this.
@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 24, 2015

Attachment friendlyNameLink.rtf added by jteh on 2015-07-24 00:01
Description:
Test case.
Update:
File added from Trac

friendlyNameLink.rtf.zip

@Adriani90
Copy link
Collaborator

This also occurs when formatting changes after the cursor is disabled. It is still reproducible in NVDA 2018.4.1.
cc: @feerrenrut

@Adriani90
Copy link
Collaborator

Wordpad will be completely removed from Windows in Windows 24 H2 update, and Microsoft confirmed that Wordpad is not being updated anymore:
https://au.pcmag.com/software-services/101488/after-28-years-microsoft-is-killing-off-wordpad
It is recommended to use either MS Word or Libreoffice or other tools for rtf documents.
In Libreoffice or MS Word this issue is not reproducible.

Wordpad will probably be still available as an optional software for download for a longer time, so we can let this open maybe someone wants to contribute at solving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants