Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation performance improvements #5293

Closed
nvaccessAuto opened this issue Aug 19, 2015 · 6 comments
Closed

UI Automation performance improvements #5293

nvaccessAuto opened this issue Aug 19, 2015 · 6 comments

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-08-19 00:52
There are several tweaks we can make to improve performance related to querying information from UI Automation. Some of the less risky changes have already been committed to master for 2015.3 (fd9d10a, 020e3f6, 8fc7574). There are some further changes in the UIASpeedup branch.

One other tweak we can make is only fetching ARIA role for Edge. We'll probably discover more as we investigate further.

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2015-08-19 00:54
UIAHandler.getNearestWindowHandle should also fetch CachedNativeWindowHandle, rather than us having to do this separately. getNearestWindowHandle can then be used to filter out UIA events from background processes (#3831), which is currently only done when CachedNativeWindowHandle isn't 0 (i.e. window elements).

@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2015-08-25 02:51
In [2c555c3]:

Merge branch 'UIASpeedup' into next

Incubates #5293.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 3 by nvdakor on 2015-08-25 15:41
Hi,
A number of regressions were observed:

  1. In Windows 10, search suggestions (Windows 10 start menu: Search suggestions are not announced automatically #5049) is broken (selected event is not caught, or if it is caught, it is not handled by suggestion items).
  2. In Disk Cleanup (at least in system mode), when attempting to delete restore points, NVDA will not announce dialog text.
    I'm sure there are more regressions as a result of this change (for others, please do let us know immediately). Thanks.

@nvaccessAuto
Copy link
Author

Comment 4 by nvdakor on 2015-08-25 16:03
Hi,
Please ignore my regression note for number 2 (a reboot fixed it); regression note 1 isn't fixed by reboots. Thanks.

@nvaccessAuto
Copy link
Author

Comment 5 by James Teh <jamie@... on 2015-08-26 03:11
In [047a459]:

Fix broken announcement of search suggestsions in the Windows 10 Start Menu (regressed by commit c32cdaa3).

Fetching of ARIA role now occurs in an Edge-specific overlay class, but this means the role won't be list item when overlay classes are chosen. To fix this, just drop the role check, since we're checking for an EdgeList parent anyway which should be sufficient.
Re #5293.

@nvaccessAuto
Copy link
Author

Comment 6 by Michael Curran <mick@... on 2015-09-21 00:51
In commit 038b8ed:
Merge branch 'UIASpeedup'. Fixes #5293
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.4 milestone Nov 10, 2015
jcsteh added a commit that referenced this issue Nov 23, 2015
…t Menu (regressed by commit c32cdaa).

Fetching of ARIA role now occurs in an Edge-specific overlay class, but this means the role won't be list item when overlay classes are chosen. To fix this, just drop the role check, since we're checking for an EdgeList parent anyway which should be sufficient.
Re #5293.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant