Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash crashing on certain websites when using NVDA and Firefox #5367

Closed
nvaccessAuto opened this issue Sep 17, 2015 · 12 comments
Closed

Flash crashing on certain websites when using NVDA and Firefox #5367

nvaccessAuto opened this issue Sep 17, 2015 · 12 comments
Assignees
@michaelDCurran
Labels
bug/app-crash bug close/worksforme

Comments

@nvaccessAuto
Copy link

Reported by ondrosik on 2015-09-17 08:41
I am using Firefox 40.0.3 and shockwave flash 18.0R0 with NVDA master 11410. In certain websites Firefox shows a erorr message, that flash addon crashed.
For example on this site:
http://www.rtvs.sk/radio/archiv/1122
(sorry for slovak site, I can not find something useful in english).
When I disable NVDA and refresh the page, everithing works. I tryed run NVDA without addons and Firefox in safe mode but result is the same.
here is the log:
Input: kb(laptop):f5
DEBUGWARNING - NVDAObjects.IAccessible.Dynamic_DocumentBrokenFocusedStateMozillaIAccessible._get_IA2Attributes (09:04:56):
IAccessibleObject.attributes COMError (-2147220995, 'Objekt nie je pripojen\xfd na\xa0server.', (None, None, None, 0, None))
DEBUG - treeInterceptorHandler.killTreeInterceptor (09:04:56):
Killed treeInterceptor: <virtualBuffers.gecko_ia2.Gecko_ia2 object at 0x05AC9EF0>
DEBUG - treeInterceptorHandler.update (09:04:56):
Adding new treeInterceptor to runningTable: <virtualBuffers.gecko_ia2.Gecko_ia2 object at 0x05AF3A10>
IO - speech.speak (09:04:56):
Speaking o 7:00 - RTVS.sk dokument zanepr\xe1zdnen\xe9'
comment: NVDA reports the title of current web page
IO - speech.speak (09:04:56):
Speaking kliknut\xed', u'zoznam m\xe1 4 polo\u017eiek', u'nav\u0161t\xedven\xfd odkaz', u'Telev\xedzia'
comment: NVDA reports the first line of the page
DEBUG - appModuleHandler.cleanup (09:04:56):
application flashplayerplugin_18_0_0_232 closed
IO - speech.speak (09:04:56):
Speaking Z\xe1suvn\xfd modul Adobe Flash zlyhal.\ufffc'
Comment: Here NVDA reports the firefox message about crashed Flash.
@nvaccessAuto
Copy link
Author

Comment 2 by ondrosik on 2015-09-17 09:54
Another good example is spotify web player https://play.spotify.com/artist/3gGbSXSwHWmrUBIG9IUAau

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2015-09-17 10:28
I was using play.spotify.com yesterday for quite some time and didn't see this. However, I did see it elsewhere some time ago. We haven't even initialised a browse mode buffer at that point, so I don't think the crash is directly caused by NVDA code. It's likely that there's some problem in the Flash accessibility code. Unfortunately, i can't debug it without being able to reproduce it on demand. I'll try with the first site you gave at some point.

@nvaccessAuto
Copy link
Author

Comment 4 by ondrosik on 2015-09-19 19:14
what's interesting that flash doesn't crash on given website, when you click wiev >style >no style in firefox. Unfortunatelly, I can not werifi this with spotify, because the play.spotify.com seems absolutly inconsistent without css and I can not find the play button.

@jcsteh jcsteh removed the Untriaged label Nov 13, 2015
@michaelDCurran
Copy link
Member

A try build with the possible fix: http://www.nvaccess.org/files/nvda/try/i5367/nvda_snapshot_try-i5367-11822,95fc219.exe

@nvaccessAuto
Copy link
Author

Incubated in 49a1c52.

@michaelDCurran
Copy link
Member

This issue depends on #5592

@Brian1Gaff
Copy link

Actually, my main issue with flash and Firefox is on bbc I player on
windows7 64bit machines where the cfg file has had the manual modification
which stops the flash crash, but content still fails to play with either the
message this content does not appear to b.. etc, or jumping out of the flash
plug in. sometimes perseverance of moving about the area will get a play
button that works, apparently randomly.
This same plug in though works with xp flawlessly, so my thoughts were in
fact that it was Windows not nvda causing the issue. Indeed running the try
snap seems to suggest this as there is no difference in behaviour between
this and other builds on nvda when used with firefox.
Internet explorer, though more fiddly with flash, involving bringing up a
context menu after pressing the object does seem to work albeit with no
spoken button names, sadly.
Brian

From: "Michael Curran" notifications@github.com
Sent: Monday, January 25, 2016 7:05 AM
To: "nvaccess/nvda" nvda@noreply.github.com
Subject: Re: [nvda] Flash crashing on certain websites when using NVDA and
Firefox (#5367)

A try build with the possible fix:
http://www.nvaccess.org/files/nvda/try/i5367/nvda_snapshot_try-i5367-11822,95fc219.exe

Reply to this email directly or view it on GitHub:
#5367 (comment)

bglists@blueyonder.co.ukSent
via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.

jcsteh pushed a commit that referenced this issue Apr 13, 2016
@michaelDCurran @jcsteh
Fixed crashes in Adobe Flash in Mozilla Firefox in some cases.
19011ae 
VBufBackend_t: hook WM_DESTROY and  call renderThread_terminate if the window being destroyed is the root of a backend. This is necessary when the destroy winEvent is not fired (e.g. Adobe Flash).
Re #5367.
@jcsteh
Copy link
Contributor

jcsteh commented Apr 13, 2016

This fix definitely covers one possible crash. However, some users are still reporting crashes even with this fix, so leaving open for now.

@derekriemer
Copy link
Collaborator

It should be noted that a friend of mine who had to do an a11y test with
jaws the other day told me that jaws crashed flash as well, which
suggests maybe it's not entirely NVDA's fault.

On 4/13/2016 12:09 AM, James Teh wrote:

This fix definitely covers one possible crash. However, some users are
still reporting crashes even with this fix, so leaving open for now.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5367 (comment)

Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

jcsteh pushed a commit that referenced this issue Apr 29, 2016
@michaelDCurran @jcsteh
Fixed crashes in Adobe Flash in Mozilla Firefox in some cases.
0f7a610 
VBufBackend_t: hook WM_DESTROY and  call renderThread_terminate if the window being destroyed is the root of a backend. This is necessary when the destroy winEvent is not fired (e.g. Adobe Flash).
Re #5367.
@jcsteh jcsteh removed the incubating label May 3, 2016
@bhavyashah
Copy link

@jcsteh Does #5367 (comment) mean that this issue has only been solved in part? If so, I would be interested in hearing from @derekriemer and others if they still experience Flash crashes with NVDA running. Regardless, it should be noted that Flash shall be discontinued by Adobe by the end of 2020.

@Brian1Gaff
Copy link

Brian1Gaff commented Aug 6, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Aug 7, 2017

We haven't had solid reports on Flash crashes for a while. Also, #6885 might have fixed some potential issues here. With the demise of Flash, this is getting less and less relevant (and harder and harder to test). Closing as works for me, but we can reopen if someone can reliably reproduce this.

@jcsteh jcsteh closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelDCurran michaelDCurran

Labels
bug/app-crash bug close/worksforme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jcsteh @derekriemer @michaelDCurran @nvaccessAuto @bhavyashah @Brian1Gaff