New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
focus existing NVDA Settings dialog if the same dialog is attempted to be opened again instead of presenting Error dialog #5383
Comments
Comment 1 by jteh on 2015-09-22 06:18 |
Comment 2 by jteh on 2015-09-22 11:44 |
Comment 3 by briang1 on 2015-09-22 11:47 I'd not know how to do this in Python though. |
Comment 4 by jteh on 2015-09-22 11:51 |
@feerrenrut, any thoughts about this? |
I haven't thought this through at all, but my first thought on how to approach this would be replacing the boolean |
Now that we have a combined settings dialog, does that make implementing this easier? I can see a situation where even with the dialog still focussed, you might be in the keyboard settings section and want to go to the voice settings, so you press NVDA+control+v. Ideally this should simply change to that settings page. |
I think it shouldn't be very difficult to do indeed. |
UX proposal:
What do you think? |
Is there any new progress on this issue? I think this kind of error prompt will make people feel unacceptable and confused. If this is improved, it will undoubtedly improve the user experience to a large extent. |
@cary-rowen - #12800 looks like an easy fix. If this doesn't fix the issue though, following it up might not be prioritised unless someone can take it over. |
… when launching a dialog which is already open (#12800) Fixes #5383 Summary of the issue: NVDA raises an error when launching a dialog, when the dialog is already open. This is unfriendly to the user, and should instead focus the open dialog. Example: Press NVDA+n to open the NVDA menu Launch the settings dialog by pressing p then s Change a setting, so that you can confirm a new instance isn't created Minimise the settings dialog window Press NVDA+n to open the NVDA menu Launch the settings dialog by pressing p then s An error message is raised Description of how this pull request fixes the issue: Set focus on existing dialog rather than raise an error if the dialog when launching a dialog which is already open. Testing strategy: Manual testing: Press NVDA+n to open the NVDA menu Launch the settings dialog by pressing p then s Change a setting, so that you can confirm a new instance isn't created Minimise the settings dialog window Press NVDA+n to open the NVDA menu Launch the settings dialog by pressing p then s Confirm the same settings dialog from before is now focused, a new instance was not created, and the error message dialog isn't opened.
Link to issue number: Follow-up of #12967 Summary of the issue: Since the merge of #12800, trying to re-open an already opened dialog allows to focus it rather than issuing an error message box. The dialog is refocused according to its class, i.e. trying to open a dialog of the same class rather refocus the first already opened dialog of the same class. But with #12800, it was not possible to open 2 dictionaries of different type (e.g. speech and default). This was fixed with #12967 by subclassing DictionaryDialog. However, addons which directly use DictionaryDialog will still have the issue of opening 2 dictionaries at once i.e. #5383. Description of how this pull request fixes the issue: force DictionaryDialog to be subclassed by making the initializer and abstract method
Reported by bhavyashah on 2015-09-21 16:57
STR
Expected Result: Focus should move to the Voice Settings dialog itself, because, apparently, the user wishes to access the same dialog.
Actual Result: The Error dialog is presented informing the user that an NVDA settings dialog is already open and only upon it closure can another dialog be opened.
My conclusive request here is that the focus move to the dialog itself when one tries to open it, unaware that it is already open. The user's ultimate intention is to access that dialog and he might still prefer the keystroke over Alt Tabbing to it if too many windows are open.
In my case, I prefer to always keep the Voice Settings dialog open alongside any work I do, because background noise around me tends to fluctuate. Accordingly, I continuously and conveniently change the volume of NVDA's speech. While closing multiple windows, or due to other reasons, I sometimes close the dialog, but, when it is already open, the Error dialog quite a bit annoys me, because it simply informs me that it is already open, and I still need to navigate to it manually.
I hope my request has been clearly expressed and substantially justified.
The text was updated successfully, but these errors were encountered: