Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse mode elements list initial selection logic is broken #5390

Closed
nvaccessAuto opened this issue Sep 24, 2015 · 2 comments
Closed

Browse mode elements list initial selection logic is broken #5390

nvaccessAuto opened this issue Sep 24, 2015 · 2 comments

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2015-09-24 04:28
The Browse mode elements list code that sets the initial selected element in the list based on the treeInterceptor selection make use if the isAfterSelection property on quickNav items. But it incorrectly assumes the opposite. In fact the TextInfoQuicknavItem's isAfterSelection has been writen to return the opposite answer anyway so that it sort of works. We should correct the TextInfoQuicknavItem isAfterSelection property and the eelements list initial selection code to correctly reflect the name of the property.

@nvaccessAuto
Copy link
Author

Comment 1 by Michael Curran <mick@... on 2015-09-24 04:37
In commit 12786cb:
Merge branch 't5390' into next. Incubates #5390
Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 2 by Michael Curran <mick@... on 2015-10-07 21:21
In commit f859d5e:
Merge branch 't5390'. Fixes #5390
Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant