Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10 Notifications and Actions Settings: Toggle buttons do not announce state change #5441

Closed
nvaccessAuto opened this issue Oct 25, 2015 · 5 comments
Closed

Windows 10 Notifications and Actions Settings: Toggle buttons do not announce state change #5441

nvaccessAuto opened this issue Oct 25, 2015 · 5 comments
Assignees
@jcsteh
Labels
bug
Milestone
2016.1

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-10-25 22:25
STR:

  1. Open Notifications and Actions Settings.
  2. Press "Select which icons appear on the taskbar".
  3. Press one of the "pressed" (enabled) buttons.
  • Expected: NVDA should say "not pressed".
  • Actual: Nothing.
    1. Press the same button again.
  • Expected: NVDA should say "pressed".
  • Actual: Nothing.

This change does get reported by Narrator. Beyond this, we might also want to consider reporting these as toggle buttons and perhaps rethink the way we report toggle buttons altogether.
@nvaccessAuto
Copy link
Author

Comment 1 by JamaicanUser on 2015-11-09 02:18
Interestingly, when moving away from the button when pressed and going back to it, if it has been toggled on/checked, NVDA reports the button as being pressed. This is what I mainly use to detect the state of some buttons.
In Jaws, as a side note, the state is reported as 'button checked' when activated and 'button' when not active. This seems to be more sensible in these cases.

@nvaccessAuto nvaccessAuto added this to the 2016.1 milestone Nov 10, 2015
jcsteh added a commit that referenced this issue Dec 3, 2015
@jcsteh
When a toggle button is focused, NVDA now reports when it is changed …
f67746d 
…from pressed to not pressed.

Fixes #5441.
@nvaccessAuto
Copy link
Author

Incubated in 445da15.

@josephsl
Copy link
Collaborator

josephsl commented Dec 5, 2015

Hi,
A number of regressions were observed:

  1. "Not pressed" is spoken on checkboxes, certain buttons and so on.
  2. the toggle button for toggling certain settings such as Tablet Mode no longer announces pressed state (this could be just mine).
    Thanks.

@josephsl
Copy link
Collaborator

josephsl commented Dec 5, 2015

Hi,
Upon further investigation, it appears toggling Tablet Mode and other items from Settings app does produce the intended result, with the first regression still remaining. Thanks.

@jcsteh jcsteh mentioned this issue Dec 7, 2015
Closed
jcsteh added a commit that referenced this issue Dec 9, 2015
@jcsteh
Don't report "not pressed" inappropriately for checkboxes and buttons…
6e85205 
… which aren't toggle buttons.

"Not pressed" is now only reported for toggle buttons. UIA buttons with the toggle pattern now get a role of toggle button.
Re #5441. Fixes #5580.
@nvaccessAuto
Copy link
Author

Incubated in 85403ad.

@jcsteh jcsteh closed this as completed in aade0a3 Jan 6, 2016
@jcsteh jcsteh mentioned this issue Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug
Projects
None yet
Milestone
2016.1
Development

No branches or pull requests
3 participants
@jcsteh @josephsl @nvaccessAuto