Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem Reading ShopRite's Website with Internet Explorer--It's Blank #5569

Closed
n2fgc opened this issue Dec 3, 2015 · 7 comments
Closed

Problem Reading ShopRite's Website with Internet Explorer--It's Blank #5569

n2fgc opened this issue Dec 3, 2015 · 7 comments
Assignees
@jcsteh
Labels
bug
Milestone
2016.1

Comments

@n2fgc
Copy link

n2fgc commented Dec 3, 2015

Good evening,

I tried to access the http://Shoprite.com website with Internet Explorer 11 and NVDA and came up blank. It started out in a search box, but when I tabbed out, all I heard all the way down the page was that lovely word, "Blank." In desperation, I quit NVDA and brought up another screen reader which read the site links and shoed me the page wasn't blank. I quit the other screen reader and started up NVDA; the links were no longer readable.

I've been given to understand that Firefox with NVDA works well on the site which is an okay work around, but for those who wouldn't know to try that solution, could you take a look at the site and help figure out how to make it and others like it work?

Thanks very much!

Lee
@jcsteh jcsteh added the bug label Dec 3, 2015
@jcsteh jcsteh added this to the 2016.1 milestone Dec 3, 2015
@jcsteh
Copy link
Contributor

jcsteh commented Dec 3, 2015

Thanks for the report.

Technical: Wow. This site is broken. It looks like the author accidentally used the wrong quote symbol in the code, so the lang attribute on the html tag is the following:

en”>
<head>
    <meta http-equiv=

instead of just the intended en. Still, we need to be able to cope with such brokenness.

What I don't quite understand yet is why our XML escaping for attribute values isn't handling this.

jcsteh added a commit that referenced this issue Dec 3, 2015
@jcsteh
In Internet Explorer, the shoprite.com website can now be read in bro…
771c32f 
…wse mode instead of reporting as blank. (Specifically, malformed lang attributes are now handled gracefully.)

Normally, the lang attribute should only contain specific characters, but it's entirely possible for an author to break this as is the case on this site. We must XML escape the language to avoid complete breakage where this happens.
Fixes #5569.
jcsteh added a commit that referenced this issue Dec 3, 2015
@jcsteh
In Internet Explorer, the shoprite.com website can now be read in bro…
49f6833 
…wse mode instead of reporting as blank. (Specifically, malformed lang attributes are now handled gracefully.)

Normally, the lang attribute should only contain specific characters, but it's entirely possible for an author to break this as is the case on this site. We must XML escape the language to avoid complete breakage where this happens.
Fixes #5569.
@nvaccessAuto
Copy link

Incubated in 046306f.

@jcsteh
Copy link
Contributor

jcsteh commented Dec 3, 2015

What I don't quite understand yet is why our XML escaping for attribute values isn't handling this.

That'd be because the language attribute is handled separately for MSHTML (and wasn't previously being escaped).

@n2fgc
Copy link
Author

n2fgc commented Dec 3, 2015

Hi there,

Well, since I don't know squat about coding, I'll just put my head back
under the pillow. :) Seriously, I wish you guys luck in sorting this as I
have seen other sites with similar broken traits.

I forgot to specify all my lovely details like the fact I'm running Win-7
64-byt with all the latest updates except those that want to force one to go
to Win-10, and my Internet Explorer version is Version 11.0.9600.18097. My
machine is a DAW-type machine, Standard Computers, ACPI with 16 Gigs ram and
Intel video, I believe. I don't know if any of that is important, but
figured I'd give you as much as I could just in case.

Again, thanks for the help!

Peace,
Lee

Do not walk behind me, | Lee Storm
I may not care to lead; | N2FGC
Do not walk before me, | n2fgc@arrl.net (or)
I may not care to follow; | mlee.n2fgc@gmail.com
Walk beside me, | Twitter: @n2fgc
And be my friend. | Skype: Lady_Chocolee

From: James Teh [mailto:notifications@github.com]
Sent: Thursday, December 03, 2015 0:25
To: nvaccess/nvda
Cc: n2fgc
Subject: Re: [nvda] Problem Reading ShopRite's Website with Internet
Explorer--It's Blank (#5569)

Thanks for the report.

Technical: Wow. This site is broken. It looks like the author accidentally
used the wrong quote symbol in the code, so the lang attribute on the html
tag is the following:

en">

<meta http-equiv=

instead of just the intended en. Still, we need to be able to cope with such
brokenness.

What I don't quite understand yet is why our XML escaping for attribute
values isn't handling this.

Reply to this email directly or view
#5569 (comment) it on
GitHub.
<https://github.com/notifications/beacon/APYbkA7JdXn3CEGcGt4mTN1vO4B81Btyks5
pL8nGgaJpZM4GtuXx.gif>

@n2fgc
Copy link
Author

n2fgc commented Dec 3, 2015

What I don't understand is why Firefox reads this page and Explorer doesn't.
Please, can you explain to the inept? :)

Do not walk behind me, | Lee Storm
I may not care to lead; | N2FGC
Do not walk before me, | n2fgc@arrl.net (or)
I may not care to follow; | mlee.n2fgc@gmail.com
Walk beside me, | Twitter: @n2fgc
And be my friend. | Skype: Lady_Chocolee

From: James Teh [mailto:notifications@github.com]
Sent: Thursday, December 03, 2015 0:49
To: nvaccess/nvda
Cc: n2fgc
Subject: Re: [nvda] Problem Reading ShopRite's Website with Internet
Explorer--It's Blank (#5569)

What I don't quite understand yet is why our XML escaping for attribute
values isn't handling this.

That'd be because the language attribute is handled separately for MSHTML
(and wasn't previously being escaped).

Reply to this email directly or view
#5569 (comment) it on
GitHub.
<https://github.com/notifications/beacon/APYbkAx6feiFiNvId8RphWJ4j62h4d1Uks5
pL882gaJpZM4GtuXx.gif>

@jcsteh
Copy link
Contributor

jcsteh commented Dec 3, 2015 via email

@n2fgc
Copy link
Author

n2fgc commented Dec 3, 2015

Thanks! I hope I didn't create too much of a kerfuffle. :) I appreciate you
addressing this so promptly!

Appreciatively,
Lee

Do not walk behind me, | Lee Storm
I may not care to lead; | N2FGC
Do not walk before me, | n2fgc@arrl.net (or)
I may not care to follow; | mlee.n2fgc@gmail.com
Walk beside me, | Twitter: @n2fgc
And be my friend. | Skype: Lady_Chocolee

From: James Teh [mailto:notifications@github.com]
Sent: Thursday, December 03, 2015 17:40
To: nvaccess/nvda
Cc: n2fgc
Subject: Re: [nvda] Problem Reading ShopRite's Website with Internet
Explorer--It's Blank (#5569)

Suffice to say that this is fixed in "next" snapshots and the fix will
be included in NVDA 2016.1.

Reply to this email directly or view
#5569 (comment) it on
GitHub.
<https://github.com/notifications/beacon/APYbkD11rKclFrhVobL-74X8a6yvRja0ks5
pMLwqgaJpZM4GtuXx.gif>

@jcsteh jcsteh closed this as completed in cb8b486 Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug
Projects
None yet
Milestone
2016.1
Development

No branches or pull requests
3 participants
@jcsteh @nvaccessAuto @n2fgc