New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please speak Split button accName #735
Comments
Comment 1 by jteh on 2010-06-29 02:43 I tested with Eclipse I20100601-0800, which is a bit old but not very. :) The first time i tested, I got a whole load of buttons with no names. I inspected the MSAA objects directly using NVDA's Python console and accName() was definitely returning NULL. I ran Narrator and also got no button names. However, I then restarted Eclipse and the button names were speaking properly. To be sure, I reverted to an earlier snapshot of my vm without Eclipse installed and installed it again. Now I can't reproduce the case where there are no button names, despite using a clean Eclipse install. I honestly have no idea what's going on here. I can tell you that we don't ignore accName() for split buttons. Leaving open until we know what's going on here. |
Comment 2 by carolyn on 2010-08-25 16:34 Anyhow, what I have done is to hook get_accName on the drop-down button child, and now MSAA, and consequently NVDA, happily speak split button names all the time. So you can close this ticket - I have made the change on my side. |
Comment 3 by jteh on 2010-08-25 20:55 MSAA doesn't really send queries like that itself. NVDA sends MSAA queries like get_accName based on the object that has the focus; i.e. fired the last focus event. If you're seeing queries to the split button's child, this suggests that you're firing a focus event for the split button's child instead of the split button itself. Although your accName fix works, I'd argue that this is the deeper problem. |
Comment 4 by carolyn on 2010-08-25 21:33 Anyhow, I have a feeling that if I explicitly fired a focus event for the split button rather than the drop-down button child, something else somewhere would be messed up, because the OS still thinks that the thing that really has focus is the drop-down button child. So it is probably best to leave in the accName hack that I have, rather than open a whole new can of worms . Thanks for the explanation, Jamie! I often forget to think of things from the client-side perspective. ;) |
Reported by carolyn on 2010-06-28 20:55
Toolbar buttons with BTNS_DROPDOWN style have MSAA role: ROLE_SYSTEM_SPLITBUTTON. In Eclipse, we give these buttons an accName, and we allow them to take focus. NVDA is not speaking the accName when one of these split buttons gets focus.
Windows version: probably any, but I am using XP SP3
NVDA version: probably any, but I am using main-3559
Eclipse version: any, but here is the download link for Eclipse 3.6:
http://download.eclipse.org/eclipse/downloads/drops/R-3.6-201006080911/eclipse-SDK-3.6-win32.zip
Steps to see the problem:
I have heard split button names spoken in other screen readers. But NVDA does not speak their name.
The text was updated successfully, but these errors were encountered: