Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vbuf table navigation commands should exclude layout tables if "Report layout tables" is disabled #774

Closed
nvaccessAuto opened this issue Jul 22, 2010 · 3 comments
Closed

Vbuf table navigation commands should exclude layout tables if "Report layout tables" is disabled #774

nvaccessAuto opened this issue Jul 22, 2010 · 3 comments
Labels
bug close/worksforme feature/browse-mode p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2010-07-22 06:49
In virtual buffers, even if "Report layout tables" is disabled, the table navigation commands do not exclude layout tables. This is extremely annoying in data tables containing layout tables in their cells, as the table navigation commands get "stuck" in the layout table, preventing you from navigating the data table.

Two things need to be done:

  • Extend !VirtualBuffer._getTableCellCoords() so that it skips layout tables if includeLayoutTables is disabled.
    • This is quite tricky because table cells do not know whether they belong to a layout table, so you have to continue to search through the fields to find the table and check its layout-table attribute. In addition, you have to keep going back in case there is a data table above.
  • Remove the forced temporary enabling of includeLayoutTables in !VirtualBuffer._tableMovementScriptHelper().
@nvaccessAuto
Copy link
Author

Attachment layoutTableWithinDataTable.html added by jteh on 2010-07-22 06:50
Description:
Test case.

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2011-01-04 05:29
Changes:
Milestone changed from 2011.1 to near-term

@nvaccessAuto nvaccessAuto added this to the near-term milestone Nov 10, 2015
@jcsteh jcsteh removed this from the near-term milestone Jun 24, 2016
@nvaccessAuto nvaccessAuto added the p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 5, 2016
@jcsteh jcsteh removed their assignment Sep 5, 2017
@LeonarddeR
Copy link
Collaborator

This was fixed in NVDA 2017.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug close/worksforme feature/browse-mode p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeonarddeR @jcsteh @nvaccessAuto