Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say all not happening when virtual buffer is loaded #83

Closed
nvaccessAuto opened this issue Jan 1, 2010 · 1 comment
Closed

Say all not happening when virtual buffer is loaded #83

nvaccessAuto opened this issue Jan 1, 2010 · 1 comment

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2008-05-02 21:59
The initial say all when a virtual buffer is loaded is no longer being triggered.

Reproduceable: almost always

Steps to Reproduce

Go to a site which does not set focus such as http://www.nvaccess.org/. Alternatively, open an email in Thunderbird.

Actual Results

Say all is not triggered.

Expected Results

The say all should be triggered once the document is loaded/receives focus.

Additional Information

This is a regression from r2008. The reason is that we now set globalVars.focusObject after calling virtualBufferHandler.update(). This means the buffer gets loaded before globalVars.focusObject is set. Unfortunately, the code that triggers a say all first checks to see if the focus object is in the virtual buffer, and because focus has not yet been updated, this is almost always false. I am not sure how to solve this without reintroducing the problem before r2008.

@nvaccessAuto
Copy link
Author

Comment 1 by mdcurran on 2008-05-03 01:25
Fixed in svn r2009. The main idea is to move the code for that speak document name / sayAll in to a place where we know its aloud to be used, rather than it having to check whether its aloud to. I.e. api.setFocusObject, and IAccessiblehandler's documentLoadEvent code are the safest places where we know its appropriate to do a sayAll.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant