Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying to the clipboard from flat review behaves badly #948

Closed
nvaccessAuto opened this issue Sep 29, 2010 · 5 comments
Closed

Copying to the clipboard from flat review behaves badly #948

nvaccessAuto opened this issue Sep 29, 2010 · 5 comments
Assignees
@michaelDCurran
Labels
bug component/display-model
Milestone
2010.2

Comments

@nvaccessAuto
Copy link

Reported by aleksey_s on 2010-09-29 20:54
STR:

  1. Open my computer properties (windows+pause)
  2. Within the flat review, set the review cursor on to last line which contains standart buttons
  3. press NVDA+f9 to mark beginning of the selection
  4. move to end of the line and press NVDA+f10 to perform the copy
  5. Open notepad and paste the copied text
    Current results:
    Only text of the first button is pasted.
    Expected results:
    The whole selected text must be pasted.
    Additional info:
    I suspect this is because the null character that is inserted between text portions when constructing a flat review representation from display model info. Therefore, replacing \0 with space or maybe \t before extracting text to be copied should be enough to fix it.
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2010-09-29 22:06
Ouch. That's a bit nasty. :) Thanks for reporting.
Changes:
Milestone changed from None to 2010.3

@nvaccessAuto
Copy link
Author

Comment 2 by mdcurran on 2010-09-29 23:28
Do we perhaps want to make textInfos.convertToCrlf in to something like a TextInfo.processTextForCopying method? then we could also convert NULLs to spaces, possibly in an overridden version of the method on DisplayModelTextInfo?
Or, we could add another property to TextInfo, such as copyableText, which in the base implementation would call return convertCrlf(self.text) but in DisplayModelTextInfo would also convert NULLs to spaces.
I think I like that idea the most.
Thoughts?

@nvaccessAuto
Copy link
Author

Comment 3 by jteh (in reply to comment 2) on 2010-09-29 23:31
Replying to mdcurran:

Or, we could add another property to TextInfo, such as copyableText, which in the base implementation would call return convertCrlf(self.text) but in DisplayModelTextInfo would also convert NULLs to spaces.

I think I like that idea the most.

Me too. This would also remove some duplicated code calling api.copyToClip() in !VirtualBufferTextInfo. Maybe we could call it clipboardText or something, though.

@nvaccessAuto
Copy link
Author

Comment 4 by mdcurran on 2010-09-30 00:08
Fixed in 85cfd61.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 5 by mdcurran on 2010-09-30 00:09
Changes:
Milestone changed from 2010.3 to 2010.2

@nvaccessAuto nvaccessAuto added this to the 2010.2 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelDCurran michaelDCurran

Labels
bug component/display-model
Projects
None yet
Milestone
2010.2
Development

No branches or pull requests
2 participants
@michaelDCurran @nvaccessAuto