Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech stutters when shift is held for more than about half a second #989

Closed
nvaccessAuto opened this issue Oct 22, 2010 · 2 comments
Closed
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2010-10-22 08:12
Str:

  1. Start NVDA reading some text.
  2. Before the text finishes, press and hold shift for more than half a second.
  3. Expected: Speech should pause. Releasing and pressing shift again should resume it.
  4. Actual: Speech stutters until shift is released.

This happens because we now pause/resume speech whenever a shift key down is received. When you hold a single key, it sends repeated key downs until it is released.

Before #601, we only resumed speech when shift was released. However, the code to do this was fairly ugly and it also caused other problems.

The solution is to avoid executing gestures for modifiers which are already down.

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2010-10-24 21:48
One problem with the solution above is that it means you can no longer hold down the control key to continually silence speech. It will only silence speech when it is first pressed. Generally, users should change the speech mode instead of doing this, but I wonder how many users have come to depend on this when they are flooded with speech.

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2010-10-25 06:23
Fixed in 68a24cc. We just ignore key repeats for the pause speech (shift) key.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants